Properly transpile exported array destructuring. #1504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
Before, it was missing a variable declaration after traspilation for identifiers used in alias assignment expressions. The cause was missing exports on actual identifiers that needed import, and ended up getting removed by the passes coming aftewards, because jsdoc_transformer was renaming identifiers destructuring statements, but not the usage of those identifiers properly because exported symbol ends up being used as `exports.identifier_destructured`, but it was being used as `identifier_destructured` pattern. PiperOrigin-RevId: 597991124
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properly transpile exported array destructuring.
Before, it was missing a variable declaration after traspilation for identifiers used in alias assignment expressions. The cause was missing exports on actual identifiers that needed import, and ended up getting removed by the passes coming aftewards, because jsdoc_transformer was renaming identifiers destructuring statements, but not the usage of those identifiers properly because exported symbol ends up being used as
exports.identifier_destructured, but it was being used asidentifier_destructuredpattern.